RickM Posted December 16, 2021 Report Share Posted December 16, 2021 (edited) Indeed Thanks @Michel KIRSCH A well deserved break, it was!! Installed and looking fantastic.. Magic stuff Good Sir!! Edited December 16, 2021 by RickM Installed Update Quote Link to comment Share on other sites More sharing options...
Jan Bastiaanssen Posted December 16, 2021 Report Share Posted December 16, 2021 Thank you Michel Quote Link to comment Share on other sites More sharing options...
Rob Roy Posted December 16, 2021 Report Share Posted December 16, 2021 Michel you are going to call me all sorts of names. I installed mod with no problems, went to add my sites to the site list and deleted the site list. Hopefully, you have a backup. Quote Link to comment Share on other sites More sharing options...
RickM Posted December 16, 2021 Report Share Posted December 16, 2021 (edited) 3 minutes ago, Rob Roy said: Michel you are going to call me all sorts of names. I installed mod with no problems, went to add my sites to the site list and deleted the site list. Hopefully, you have a backup. All Sorts of Names!!! Bugger!!!!!! 😁 I think that can be sorted.. Thank God for backups.. hahahahahahaha The Wiki page looks ok Rob, try again Good Sir.. Edited December 16, 2021 by RickM Looks ok Rob Quote Link to comment Share on other sites More sharing options...
Rob Severijns Posted December 16, 2021 Report Share Posted December 16, 2021 Ouch.... ☺️ Quote Link to comment Share on other sites More sharing options...
Rob Roy Posted December 16, 2021 Report Share Posted December 16, 2021 All fixed now. As for the name-calling, being a sailor, it isn't anything I haven't heard before. Quote Link to comment Share on other sites More sharing options...
tngrlkrz Posted December 16, 2021 Report Share Posted December 16, 2021 Great work (as always) Michel. Thanks for adding the display option '3' for age being (Age xx) which now matches the rest of my site age displays (e.g. name header, children, spouses, and other pages). BTW....the parameter default for display in the cfg is set at '4', yet only 3 options. Had you been thinking of yet another? 😉 Quote Link to comment Share on other sites More sharing options...
Rob Roy Posted December 16, 2021 Report Share Posted December 16, 2021 Ok, I quit. did it again, and not sure what I did wrong. Table has disappeared. Quote Link to comment Share on other sites More sharing options...
RickM Posted December 16, 2021 Report Share Posted December 16, 2021 Table is there Rob DM me the details you want added I will do it for you if you like.. Quote Link to comment Share on other sites More sharing options...
Rob Roy Posted December 16, 2021 Report Share Posted December 16, 2021 I sent them to Michel. I think I didn't save so it reverted. Quote Link to comment Share on other sites More sharing options...
RickM Posted December 16, 2021 Report Share Posted December 16, 2021 No worries.. You could be right in your thoughts there.. You have'n one of them days/night.. I have those very regularly! Quote Link to comment Share on other sites More sharing options...
Michel KIRSCH Posted December 16, 2021 Report Share Posted December 16, 2021 44 minutes ago, tngrlkrz said: the parameter default for display in the cfg is set at '4', Ach! Scheisse ! This was a test. I forgot to reset the default value before posting the Mod... If value is not in (1..3) the default value 1 is set... Will post an new version. But don't load this will be for the future uploaders... Quote Link to comment Share on other sites More sharing options...
Michel KIRSCH Posted December 16, 2021 Report Share Posted December 16, 2021 48 minutes ago, tngrlkrz said: the parameter default for display in the cfg is set at '4 It's fixed ! Thanks "Big Eye" Ron ! Quote Link to comment Share on other sites More sharing options...
Michel KIRSCH Posted December 16, 2021 Report Share Posted December 16, 2021 43 minutes ago, Rob Roy said: I sent them to Michel. I think I didn't save so it reverted. It's Done, Rob. Michel Quote Link to comment Share on other sites More sharing options...
Michel KIRSCH Posted December 16, 2021 Report Share Posted December 16, 2021 2 hours ago, Rob Roy said: Michel you are going to call me all sorts of names Never, Rob. Never... Quote Link to comment Share on other sites More sharing options...
RickM Posted December 16, 2021 Report Share Posted December 16, 2021 1 hour ago, Michel KIRSCH said: It's fixed ! Thanks "Big Eye" Ron ! Well done Mr 'Big Eye' Ron! Well Done Michel.. Always on top of things.. Quote Link to comment Share on other sites More sharing options...
Michel KIRSCH Posted December 17, 2021 Report Share Posted December 17, 2021 A new version 1a is (already) published. When changing parameters, the mod can display as "partially installed" It is the answer to the problems encoutered by Rob the sailor et Rob the not sailor. When modifying a parameter, it was modified once in personlib.php and twice in the cfg file... Michel Quote Link to comment Share on other sites More sharing options...
RickM Posted December 17, 2021 Report Share Posted December 17, 2021 1 hour ago, Michel KIRSCH said: A new version 1a is (already) published. Nicely caught Team!!! Quote Link to comment Share on other sites More sharing options...
tngrlkrz Posted December 17, 2021 Report Share Posted December 17, 2021 2 hours ago, Michel KIRSCH said: When changing parameters, the mod can display as "partially installed" You know, I had that happen to me a couple times and just put it off to some install mess I created, so I did a 'cleanup', I think. Thanks also putting an explanation (below) within the cfg file. It makes total sense to me now knowing how Mod Manager processes parameter changes after installation. //version 1a : because mod manager change all occurrences of the parameter when changed, the parameters name must be unique (from the inline code variables) ! Thanks for the enlightenment! Quote Link to comment Share on other sites More sharing options...
Michel KIRSCH Posted December 17, 2021 Report Share Posted December 17, 2021 More explanation : in the cfg file : $aae_aftfact = 1; // displays age after the fact .... if ($aae_aftfact == 0 && $aae_beffact == 0 && $aae_aftdate == 0 && $aae_2lines == 0) $aae_aftfact = 1; // Set display after fact as default When changing $aae_aftfact from 1 to 0, in the edit option of the Mod, the 2 occurences in the cfg file are modified ==> $aae_aftfact = 0; While in personlib.php, only the line with the parameter is modified... and the mod is considered as "partially installed". This is annoying, but there is more serious: the logic is changed in the cfg file. So after a Clean Up and a reinstall of the Mod, the code doesn't work properly anymore! 😮 Michel Quote Link to comment Share on other sites More sharing options...
Ken Roy Posted December 17, 2021 Report Share Posted December 17, 2021 2 hours ago, Michel KIRSCH said: When changing parameters, the mod can display as "partially installed" Editing options should not cause a partially installed mod. Having stated that, some of Bart Degryse's mod that updated the TNG configuration files required that the cfg file be update if you made a change using the TNG Admin > Setup dialogs. Quote Link to comment Share on other sites More sharing options...
tngrlkrz Posted December 17, 2021 Report Share Posted December 17, 2021 19 minutes ago, Michel KIRSCH said: after a Clean Up and a reinstall of the Mod, the code doesn't work properly anymore I followed you and understand the need for parameter vs. code and the requirement for uniqueness...but didn't realize the mod manager is left with an inability to 'cleanup'. Quote Link to comment Share on other sites More sharing options...
Ken Roy Posted December 17, 2021 Report Share Posted December 17, 2021 That is because Edit Options cannot be coded the way Michel coded his mod where changing on option impacts the other options. The options can have more and true and false or 0 and 1. The Edit Options should be coded for how you want the display to work (6) $displayAS = 1 => displays : (45 years) => this is the default case 2 => displays : (45 years old) 3 => displays : (Age 45) Quote Link to comment Share on other sites More sharing options...
Rob Roy Posted December 18, 2021 Report Share Posted December 18, 2021 Rob the Sailor is an honorable title. Quote Link to comment Share on other sites More sharing options...
Rob Severijns Posted December 18, 2021 Report Share Posted December 18, 2021 An honorable title it is Rob. Eventhough I've never been a sailor I did travel the world and do have some sailorsblood running through my vanes.. My grandfather via my mothers side was a skipper and his forfathers before him were sailors. Two of my forfathers drowned at sea. One during a storm in Kattegat, close to Danmark, and the other in the Spanish Sea. Both were married to the same woman. She lost two of her husbands within a year after their marriage leaving her a widow twice with 2 children of two different fathers. Life can be harsh. Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.