Collapse Notes Field

[Brett]

Having a look now Hanne/Michel.

This has occurred before with 2 different Mods.

My notes indicate Mod code remnants were the problem before, so will uninstall all Hanne's mods, replace affected files with clean files and start again.

 

[Brett]

This particular error does not appear to be Mod related. What was causing the problem is the Root Path for the test site was pointing to the live site. This is different to the previous 2 occasions I have seen this happen.

I have updated the Root Path and will restore affected files in both sites.

Hanne - I will work on this through the day and finish tonight. I will PM you when complete. At this stage, do not do any work on the test site.

[Hanne B. Stegemüller]

9 hours ago, Brett said:

Hanne - I will work on this through the day and finish tonight. I will PM you when complete. At this stage, do not do any work on the test site.

Thanks Brett

I will stay away

I guess the mistake with the Root Path has happened when I just copied all the files from the live site to the test site. This does not use to be an issue.

[Hanne B. Stegemüller]

16 hours ago, Michel KIRSCH said:

Thx, I've noted your address.

You can transllate this one for when the Mod installs fine on your site

// Hide big notes - MichelKirsch
$hbn_text['adminlongnote'] = " This note is more than xxx characters long. Click on the arrow on the left to display it.";
$hbn_text['longnote'] = "Click on the arrow on the left to display this note.";
// Hide big notes - MichelKirsch

 

Hi Michel

The Mod runs like a dream on my live site! If you feel like, you can see it working on my father: https://tng.stegemueller.dk/getperson.php?personID=I630&tree=HBS where there is a really long note at the bottom. Thank you for all your genial mods!.

Translation into Danish:

$hbn_text['adm inlongnote '] = " Denne note er mere end xxx tegn lang. Klik på pilen til venstre for at vise noten. " ;

$hbn_text['longnote'] = "Klik på pilen til venstre for at vise noten.";

[Brett]

4 minutes ago, Hanne said:

there is a really long note at the bottom

Hanne/Michel

The page referred to by Hanne  https://tng.stegemueller.dk/getperson.php?personID=I630&tree=HBS shows the Notes Collapse in operation. It also shows similar for Events and Photos.

I note that Sources MAY benefit from a similar collapse.

[Michel KIRSCH]

3 hours ago, Hanne said:

Translation into Danish:

Thanks. is now included in the actual version 1b.

3 hours ago, Brett said:

I note that Sources MAY benefit from a similar collapse

Brett, it's more difficult because Sources are the destination of internal links...

and is it usefull? Sources are displayed at end of page. It's less annoying.
may be display them in a continuous field instead a scrollable field?

Michel

[Hanne B. Stegemüller]

3 minutes ago, Michel KIRSCH said:

Thanks. is now included in the actual version 1b.

Brett, it's more difficult because Sources are the destination of internal links...

and is it usefull? Sources are displayed at end of page. It's less annoying.
may be display them in a continuous field instead a scrollable field?

Michel

You can always ask for translations!

From my personal point of view there is no need to collapse the sources.

[Michel KIRSCH]

Noted !

Michel

[Ken Roy]

2 hours ago, Michel KIRSCH said:

Brett, it's more difficult because Sources are the destination of internal links...

Michel and Brett

Before you embark on another programming effort maybe you should check out the Collapsible Items article on the TNG Wiki, which documents the changes made in TNG 10 that allowed collapsing sections.  You might be able to change the notearea css class to reduce the height of the Souce / Citations section.

[Michel KIRSCH]

Thanks Ken.

Nothing new for me except the collapse of media fields (never tried before).

Michel

[bhemph]

6 hours ago, Hanne said:

I guess the mistake with the Root Path has happened when I just copied all the files from the live site to the test site. This does not use to be an issue.

Hanne,
     The config and subroot files are two files that cannot just be copied from one environment to another.  Doing so can have strange results from the path changes.  To match your Setup >> General Settings between your test and live site, it is best to compare the two screens and make those changes manually since then you can see the path options that really should be different and keep them correct to not have live and test getting mixed up.

Brent

[Hanne B. Stegemüller]

3 minutes ago, bhemph said:

The config and subroot files are two files that cannot just be copied from one environment to another.

Thanks Brent,

I realize and I will remember from now on! I must be wrong, that it has not been an issue before.

[Hanne B. Stegemüller]

Now I hope I am not doing a silly mistake (again)

I have this version "collapse_notes_v13.0.3.1b.cfg", and I re-downloaded and re-installed it when the description was changed by Michel to this "Collapse the notes longer than the limit you fix. v 1b collapse event notes too. + danish language"

Issue: I still get the English text on my Danish version, "This note is more than 300 characters long. Click on the arrow on the left to display it." though my Danish cust_txt.php has this content:

// Hide big notes - MichelKirsch
$hbn_text['adminlongnote '] = " Denne note er mere end xxx tegn lang. Klik på pilen til venstre for at vise noten.";
$hbn_text['longnote'] = " Klik på pilen til venstre for at vise noten.";
// Hide big notes - MichelKirsch

In the Mod Manager I get these messages - everything should be fine:

line 425: %target:@languages/Danish/cust_text.php% verified

line 428: %location:% #1 Installed

line 440: %target:@languages/Danish-UTF8/cust_text.php% verified

line 443: %location:% #1 Installed

---

• code modifications specified: 20; modified: 20
• file copies specified: 0; copied: 0
• new files specified: 0; created: 0
• new folders specified: 0; created: 0
• errors: 0

Do I do something wrong?

[Michel KIRSCH]

Maybe trying in Dansk language, not in english ?

It works for me Hanne. The message appear well in Dansk...

Michel

Edited May 16, 2021 by Michel KIRSCH
add image

[Hanne B. Stegemüller]

1 minute ago, Michel KIRSCH said:

Maybe trying in Dansk language, not in english ?

It works for me Hanne. The message appear well in Dansk...

Michel

Hrm... strange. And I have of course cleared cache.

I don't quite understand, what you mean Michel.

[Brett]

8 hours ago, Michel KIRSCH said:

may be display them in a continuous field instead a scrollable field

Thanks Michel

It was just a thought I had.

General setting does allow scrollable to be turned of and have all displayed.

I was only thinking of a consistent look when other fields have the collapse arrow.

[Hanne B. Stegemüller]

I don't know whether this is interesting for anybody but me:

In cust_text.php for Danish and for Danish-UTF8 I had a space too much in "$hbn_text['adminlongnote ']" which of course resulted in English text when logged in. As soon as I removed the space to what is shown below, I also got the Danish text when logged in.

// Hide big notes - MichelKirsch

$hbn_text['adminlongnote'] = " Denne note er mere end xxx tegn lang. Klik på pilen til venstre for at vise noten.";

 

 

 

[Michel KIRSCH]

1 hour ago, Hanne said:

I don't know whether this is interesting for anybody but me:

maybe other danish user?

Will make the change.

Michel

[Hanne B. Stegemüller]

Solid humour!

Thanks.