Mod Testing: Military service ribbon

[stackos]

I'm excited and nervous about this. This is the first mod I have ever done, and I've been teaching myself PHP on the side. So be gentle on the feedback! Being an Army brat and veteran myself...I wanted to teach myself how to make something stand out that shows an individual who served in the military whether volunteered or drafted.

Here is the ZIP file.
veteran_status_badge_v15.0.5.zip

This is Version 1. I wanted to make sure I could even make a mod and chose Template 21.

Version 2 Goal - All TNG v15 template compatibility. TNG Mod Wiki written to make the mod official.

Version 3 Goal - I have an end goal for this mod, but want to make sure I can get Version 2 done and launched successfully.

Questions:

Cosmetically. How does it look?

Event IDs. Did I cover all of them? United States based. I do plan on adding global event IDs.
 

AND (
        e.eventtypeID = \"MILI\"
        OR et.tag = \"MILI\"
        OR et.display LIKE \"%Military%\"
        OR et.display LIKE \"%Veteran%\"
        OR et.display LIKE \"%Service%\"
        OR et.display LIKE \"%War%\"
        OR et.display LIKE \"%Soldier%\"
        OR et.display LIKE \"%Army%\"
        OR et.display LIKE \"%Navy%\"
        OR et.display LIKE \"%Marine%\"
        OR et.display LIKE \"%Air Force%\"
        OR et.display LIKE \"%Coast Guard%\"
        OR et.display LIKE \"%Confederate%\"
        OR et.display LIKE \"%Union Army%\"
        OR et.display LIKE \"%Civil War%\"
        OR et.display LIKE \"%Revolutionary War%\"
        OR et.display LIKE \"%World War%\"
        OR et.display LIKE \"%WWI%\"
        OR et.display LIKE \"%WWII%\"
    )
    LIMIT 1";

Final question: Anything I should patch prior to testing other templates and start writing the Wiki page for this mod and asking for testers?

[Chris Lloyd]

Interesting idea, I would be interested in testing but my military ancestors were British, African, German, Welsh ans served in wars such as Boer, Afgan, WWi, WWii, Korean, Malaysian confrontation, Rhodesian UDI, Falklands and Vietnam (I also served there)

[stackos]

2 hours ago, Chris Lloyd said:

Interesting idea, I would be interested in testing but my military ancestors were British, African, German, Welsh ans served in wars such as Boer, Afgan, WWi, WWii, Korean, Malaysian confrontation, Rhodesian UDI, Falklands and Vietnam (I also served there)

Even if I was just to label the Country of Service it would be a huge undertaking. Right now I'm just going to keep it to basic eventIDs while I prospect this option for a later release version. Creating mods is addicting, but have to remember to do things in stages.