Jump to content
TNG Community
RickM

Edit facilities - note edition Mod

Recommended Posts

RickM

Hi @Michel KIRSCH

Love this new mod you have created.It even works out of the box with my private mods.. (Real Bonus)..

Not sure if the intention was there for it to occur, it appears one cannot edit Events. Would that be something easily added??

I have attached a screen shot for you..

If I can be of any help please ask..

An Admirer

Rick M

Edit facilities - note edition.jpg

Share this post


Link to post
Share on other sites
klooster

Schermafbeelding 2021-10-13 om 06.49.31.pngI I

 

I also have a lot of Events, like Research, Education, Health, Hobby, Obituary, Occupation, Emigration, Immigration, Fact, Residence, Military etc.  I agree, that would be a great idea to be able to edit those events also in this easy way. Can you accomplish that Michel??

Share this post


Link to post
Share on other sites
Michel KIRSCH

Will check soon. Think it's possible.

Michel

Share this post


Link to post
Share on other sites
Michel KIRSCH
8 hours ago, RickM said:

Not sure if the intention was there for it to occur, it appears one cannot edit Events.

No Rick. A note is a note. Nothing to see with an event...

Michel

Share this post


Link to post
Share on other sites
RickM
43 minutes ago, Michel KIRSCH said:

No Rick. A note is a note. Nothing to see with an event...

Michel

Fair enough, although you can add notes to the event.. 😅

Update: WRONG one might call it a note, but it is in fact adding details to the event.. DOH!!

Rick

Edited by RickM
Ok I looked at it in more detail

Share this post


Link to post
Share on other sites
Michel KIRSCH
47 minutes ago, RickM said:

Update: WRONG one might call it a note, but it is in fact adding details to the event.. DOH!!

Yes but you can attach a note to an event. In this case, this note is directly editable too !

Share this post


Link to post
Share on other sites
Rob Severijns

Hi Michel,

Yet another great mod :-)

Here's a Dutch translation;

//Edit facilities - Note edition
$text['return_to_origin'] = "Opslaan en terug";
//Edit facilities - Note edition

Rob

Share this post


Link to post
Share on other sites
Michel KIRSCH

Thx Rob.

For next upgrade !

Michel

Share this post


Link to post
Share on other sites
Michel KIRSCH
On 10/13/2021 at 3:43 AM, RickM said:

Would that be something easily added??

 

On 10/13/2021 at 6:48 AM, klooster said:

Can you accomplish that Michel??

This very little Mod do the job, but (actually) you must do a manual refresh to see the result on getperson.php.

Let me know if it is acceptable for you...

Michel

 

 

Share this post


Link to post
Share on other sites
RickM
6 hours ago, Michel KIRSCH said:

 

This very little Mod do the job, but (actually) you must do a manual refresh to see the result on getperson.php.

Let me know if it is acceptable for you... 

Michel

 

edit_facilities-event_edition_v13.0.4.1.zip

Michel,

That is very cool.. IF you are going to make it public, would you be able to include a class for the image such as class="efe-editimage"? It would for those of us who use Wordpress make it so much easier to style up to suit our layout.. And prob allow TNG users to do the same..

Brilliant effort Michel.. Thank You

Share this post


Link to post
Share on other sites
Michel KIRSCH

As this one?

Don't know why, but if i declare the class in mytngstyle, it doesn't work.. An idea?

Michel

 

Share this post


Link to post
Share on other sites
RickM

This works for me.. I note in version 1a, you do not specify the image as you did in version 1

// Edit Facilities - Event edition - Michel KIRSCH
            echo "<script type=\"text/javascript\" src=\"js/selectutils.js\"></script>";
            $_SESSION['ef-ee_page_to_return'] = "getperson.php?personID=$entityID&tree=$tree";
            $displayval = $displayval . "<a href=\"#\" onclick=\"return editEvent({$custevent['eventID']});\" title=\"Edit\" ><img class=\"efe-editimage\" src = \"img/tng_edit.gif\"></a>";
// Edit Facilities

 

And thank you for looking into this Michel

 

Rick M

Share this post


Link to post
Share on other sites
klooster

Thanks Michel and Rick, this works fine, now I can style the gif.

Question: If I am logged out, I am still able to edit the event. This should be only be possible for logged in user with administrator rights.

Rick or Michel can you check this on my site, https://www.kloosterman.be/genealogy/getperson.php?personID=I2173&amp;tree=001

Can you edit an event????

Share this post


Link to post
Share on other sites
Michel KIRSCH

Cees,

the Mod is certinaly not finished !  I just want to have your opinion on the first design !

It must be protected"allow_edit" only. (and one or two parmeters if possible...)

Question : why have your event no title? is it normal? Or is it the Mod?

Wait...

Michel

Share this post


Link to post
Share on other sites
Michel KIRSCH
4 hours ago, RickM said:

you do not specify the image as you did in version 1

I'm really not a king with css...

The image is defined in the class. Is it not enough?

/* Edit facilities - Event edition - Michel Kirsch edit icon */
.ef-ee-editicon {
    margin:0px 2px 0px 2px;
    border:0px;
    width:20px;
    height:20px;
    display:block;
    float:right;
    background:url('../img/tng_edit.gif') no-repeat;
    padding:0px;
}
/* Edit facilities */

 

Share this post


Link to post
Share on other sites
klooster
  • Hi Michel, the Events do have aTitle, Research, Education, Health, Hobby, Obituary, Occupation, Emigration, Immigration, Fact, Residence, Military etc.
  • I like the design as it is.
  • The image is defined in the class, that's enough..

 

PS: I switched the Mod off, until it is protected "allow_edit" only. 

Share this post


Link to post
Share on other sites
Michel KIRSCH
9 minutes ago, klooster said:

until it is protected "allow_edit" only.

Done.

The edit icon is now part of the parameters.

If you think to somethings else, let me know before promotion...

Michel

Share this post


Link to post
Share on other sites
Michel KIRSCH
22 hours ago, Rob Severijns said:

Here's a Dutch translation;

The version 1 (version number unchanged) is updated with Dutch translations !

Michel

Share this post


Link to post
Share on other sites
RickM

 

4 hours ago, Michel KIRSCH said:

I'm really not a king with css...

The image is defined in the class. Is it not enough? 

Hey Michel

No, you need to have an element to add css to as in the original code you wrote, add the class to that, like I have done in my example above, then style it. Your styling would then work, you would not need the background tag..

I'm not king with css either, 🤣, you though are a king with php!! Thank you..

 

Rick M

Share this post


Link to post
Share on other sites
Rob Severijns
1 hour ago, Michel KIRSCH said:

The version 1 (version number unchanged) is updated with Dutch translations !

Thx :-)

 

Share this post


Link to post
Share on other sites
Michel KIRSCH
23 hours ago, Michel KIRSCH said:

you must do a manual refresh to see the result on getperson.php

OK gus. Now automatic refresh. So 2 clicks instead 5... Can't do more...

Promotion soon. Looking for a last idea...

Michel

2 hours ago, RickM said:

Your styling would then work, you would not need the background tag..

Done Rick

Share this post


Link to post
Share on other sites
RickM
1 hour ago, Michel KIRSCH said:

Michel

Done Rick

Brilliant

 

35 minutes ago, Michel KIRSCH said:

Think it's finished.

Try this beta2 version and let me know (which browser are you using?)

Michel

edit_facilities-event_edition_v13.0.4.2.zip

I'll be on it as soon as I finish here.. Will post an update..

 

You are a magician with these Mods Michel, Thank  You..

Share this post


Link to post
Share on other sites
Michel KIRSCH

Searching to implement a solution to delete the event in the same window... (as in the edit note mod)

Share this post


Link to post
Share on other sites
RickM
10 minutes ago, Michel KIRSCH said:

Searching to implement a solution to delete the event in the same window... (as in the edit note mod)

That would be interesting Michel.. Thanks..

Have the Edit Event Mod b2 installed, it seems to be just fine.. Thank you for the addition of the class for the image..

Share this post


Link to post
Share on other sites
Guest
You are commenting as a guest. If you have an account, please sign in.
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Loading...

×