Jump to content
TNG Community
Michel KIRSCH

Group Custom Events Mod

Recommended Posts

Michel KIRSCH

Jürgen,

sorry, i was busy on MSExcel problems ...

The sorting dates problem is fixed for the next version.

Have 2 or 3 things to do before promote it. (pictures...)

What about the switch between languages?

Michel

Share this post


Link to post
Share on other sites
JPB
vor 20 Stunden schrieb JPB:

To display an inaccurate date in another language TNG does automatically change the language of the entry (if I enter the date in English!). Unfortunately not when the Mod is installed.

I don't know how else to explain it.

My website works in German. So all date fields, even the inaccurate ones, are automatically shown in German.

Example: I enter for a residence "between 1911 and 1912" (I have to enter it in English!) it is normally displayed as "zwischen 1911 und 1912".

But if the Mod is installed, the date in the block for residences remains as entered (between 1911 and 1912).

This works for all other date fields, but not in the block for residences.

Don't be in a hurry, you're already doing a lot of good things for us.

Jürgen

Share this post


Link to post
Share on other sites
Michel KIRSCH

OK Jürgen,

can reproduce the problem... will search for a solution

Michel

Share this post


Link to post
Share on other sites
Michel KIRSCH
On 3/21/2021 at 9:31 AM, JPB said:

If I prefix the date with something (for example "from 1901 to 1902" or "aft 1903" etc.), the entry is moved to the end

Working on two Mods in the same time is ....

I presume you are speaking about Regroup Events Mod?

I fix the problem. Must work on the pictures...

If there are other problems with Regroup Associations, open a new topic for Regroup Associations

I change the title for this topic in "Regroup Events Mod"

(My fault...)

Michel

Share this post


Link to post
Share on other sites
Michel KIRSCH

I'm actually busy on watermark Mod with Brent.

Be patient...

Michel

Share this post


Link to post
Share on other sites
Michel KIRSCH
On 3/13/2021 at 10:30 AM, JPB said:

Could there be a sorting option on the admin input? For example, as with the Notes.

Jürgen,

sorry but after 3 tentatives, I must lay down my arms!
The original code is too complicated for me to modify it to what you ask...

On 3/20/2021 at 6:23 PM, JPB said:

The picture to Amsterdam belongs to the top and the last line "to Oct 1657 - Soubise, FR-17" should be the first line

I continue to works on the pictures, but i'm not optimistic...

Michel

Share this post


Link to post
Share on other sites
Michel KIRSCH
3 hours ago, Michel KIRSCH said:

Could there be a sorting option on the admin input? For example, as with the Notes.

I spoke too fast.... It works!

Michel

Share this post


Link to post
Share on other sites
fluffy82

Just a tiny little remark, you do with it what you want of course...

But @Robin Richmond already has a whole series of mods called "Regroup [insert name]". These are all perfectly intertwined and adjusted to work with each other. If you call this one "Regroup Events", that might be confusing to users...

I would suggest that you either change the name, or make sure it is fully compatible with the other Regroup mods. Just for clarity's sake. No?

Share this post


Link to post
Share on other sites
Michel KIRSCH
1 hour ago, fluffy82 said:

I would suggest that you either change the name

Hi Tom,

I can't call this Mod "Regroup each event you want" or "Regroup OCCU, RESI, NAME,.... events" because this Mod can group all the events you designate in a list.
If you have an idea for the name, i take it ! (Regroup events on demand?)

As for whether it installs well with all of Robin's Mods, I'm counting on the user-testers to tell me.
I can't install all Robin's Mods to do the tests myself. Have you tested the Mod?

Currently, I'm facing a problem with the media attached to an event...
I don't think I can solve it with my current method...
I think I'll have to revise it from scratch...

Michel

Share this post


Link to post
Share on other sites
Ken Roy

Michel,

I think what Tom is objecting to is the use of "Regroup" as part of your mod name.  I agree that users will easily confuse the mod as being one of Robin's and not yours.

Maybe change the name to simply "Group Events" or "Group/Hide Events"  depending on the purpose of the mod

Share this post


Link to post
Share on other sites
Michel KIRSCH

I understand Ken.

Nothing is fixed while the Mod is on the wiki. I'm fighting with these $#@ of pictures attached to the event....

I will consider your obervations and those of Tom...

Michel

Share this post


Link to post
Share on other sites
Ken Roy

Michel,

Pictures attached to events have always been an issue in TNG since the eventIDs might change when you import and the links get broken.

How you name your mod is of course up to you.

 

 

Share this post


Link to post
Share on other sites
Katryne

Don't change the name, Michel. I've got used to it and it does what it says.

Share this post


Link to post
Share on other sites
fluffy82
4 minutes ago, Katryne said:

Don't change the name, Michel. I've got used to it and it does what it says.

It won't stop working if you change the name you know... But it will cause less confusion with other users.

Share this post


Link to post
Share on other sites
fluffy82
8 hours ago, Ken Roy said:

I think what Tom is objecting to is the use of "Regroup" as part of your mod name.  I agree that users will easily confuse the mod as being one of Robin's and not yours.

Maybe change the name to simply "Group Events" or "Group/Hide Events"  depending on the purpose of the mod

Yes, that was what I meant :)

Share this post


Link to post
Share on other sites
Michel KIRSCH

To close this thread...

The code is new, the name too...

Please download the new version which takes media in account :

Group custom events 13.0.0.1 on https://tng.lythgoes.net/wiki/index.php/Group_custom_events

Michel

Out

Share this post


Link to post
Share on other sites
Michel KIRSCH

... and already an update: Event editing was not working (line commented too quickly in the code...)
Sorry for the inconvenience...

Michel

Share this post


Link to post
Share on other sites
ton van lil

Micheal,

I cannot install the Group custom events mod and get an error.

image.png.2926e54622609bc511ad00b48c39938f.png

If I look into it I see that it's looking for

0093: %location:%
0094:return $prntchildren;

in personlib.php.

$prntchildren is not found.

What do I do wrong?

Greetings

Ton van Lil


 

 

image.png

Share this post


Link to post
Share on other sites
Michel KIRSCH

Hi Ton,

My fault.

This "return $prntchildren; makes part of a Mod and is not signaled as part of a Mod.

I will produce a new version which works on a clean personlib.php...

Will let you know.

Michel

 

Share this post


Link to post
Share on other sites
ton van lil

Thanks Michel.

So far working like a dream.

Greetings Ton

Share this post


Link to post
Share on other sites
Michel KIRSCH

Yes.

And with the newer version 1c, Dutch, German and English languages are added.

The "Click arrow" message is displayed only if needed (collapse = 1 for the event)

You can download it now

Michel

Share this post


Link to post
Share on other sites
ton van lil

Michel

Tested the mod and it is working great.

There are only a few side affects.
-an edit pencil is added at the end of the text. This is very handy for administrators but it also visible for users who are not aloud to edit. They can not use it but it is there.
-the magnifying glass after the place or address of an event is gone. 
-the Event Map is not showing the custom events any more. Only the birth, married and died is visible.

Greetings

Ton

Share this post


Link to post
Share on other sites
Michel KIRSCH

Hi Ton,

thanks for the tests.

- Pencil : it's fixed for next version.

- Magnifying glass I already know about it. I'll check tomorrow (or the next day) if it's possible. (The place is no more a TNG place but a concatenation of 3 strings).
- Event Map : I'm afraid that's the price to pay for using the Mod. But I'll check what can be done.

- You probably didn't see it, but the sources are not displayed in the event either
Michel

Share this post


Link to post
Share on other sites
Katryne

Hello Michel !

Event map is important to me and Group custom events makes the page both elegant and condensed. How can you ask me to choose between them ?

Share this post


Link to post
Share on other sites
Guest
You are commenting as a guest. If you have an account, please sign in.
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Loading...

×