FYI: TNG 13.0.3 and Mods

[tngrlkrz 0]

FYI regarding TNG 13.0.3.

These are the mods I am aware of that had conflicts with TNG 13.0.3.  There are likely others.

• Regroup Person Profile
• Fixed Family Tabs  -- new version posted by Erik H. Fixed_Family_Tab
• Show Branch Members -- This is mod has been superceded, no longer on the Wiki. Was replaced by Regroup_Person-Branch_Members , which installs fine on TNG 13.0.3
• Mobile Site Enhancements  new version posted by Ken R.: Mobile_Site_Enhancements
• Show All Family  ---new version posted by Scott D. :Show_All_Family
• Admin Families Plus --new version posted by Michel K. on behalf of Jeff R. Admin_Families_Plus

There was a database update script in coming from TNG 13.0.2 as well.

 

[theKiwi 0]

4 hours ago, tngrlkrz said:

• Fixed Family Tabs

To fix this until a new version is released, edit line 150 of the .cfg file to remove the underscore that is in front of 

target=\"_blank

partway across that line.

Roger

[tngrlkrz 0]

26 minutes ago, theKiwi said:

To fix this until a new version is released, edit line 150 of the .cfg file to remove the underscore that is in front of 

target=\"_blank

partway across that line.

Roger

Yea, Roger, 

I made that fix privately a couple days ago, and was following 'protocol' to wait until the author has a chance to react or someone who uses it posts an issue.  But, no problem, Erik will appreciate it.

[XerxX 0]

16 hours ago, theKiwi said:

remove the underscore that is in front of 

target=\"_blank 

Yes, Thank you Roger.

A very strange code-change, in my opinion: HTML code becomes non-HTML for some reason...?

My modification keeps the underscore, however. I tested and it seems to work also without it.

 

I also corrected an error:

Clicking on a "family image" (either in the Family part of getperson.php or at familygroup.php) displays the image and tabs. Clicking an individ tab gives a 404 error.

Not so now - for v13.0.0 (& 1 & 2) and 13.0.3

Posted just now:

https://tng.lythgoes.net/wiki/index.php?title=Fixed_Family_Tab

 

Stay Safe!

Erik

[tngrlkrz 0]

Hi Erik,

in Fixed Family Tab v13.0.3.3 mod,  I think it should be a 'replace' rather than an 'insert:after' for the showmedia.php changes.  Otherwise one ends up with double headers; the old non-working one, and the working one below it.😉

%target:showmedia.php%

** Mod 1/1

%location:%
    echo tng_menu( $linktype, $type, $personID, " " );
%end:%
%insert:after%  change to %replace:%

/* START MOD: Fixed Family Tab v13.0.3.3 (1/1) */

    if ($linktype == "F") {
        $familyID = $personID;
        $personID = setSESSpersfamID($personID, 1);
    } elseif ($linktype == "I") {
        $familyID = setSESSpersfamID($personID, 0);
    }
    echo tng_menu( $linktype, $type, $personID, " ", $familyID);

/* END MOD: Fixed Family Tab v13.0.3.3 (1/1) */

%end:%

But thanks for finding this long standing bug!

[XerxX 0]

NOOO!

Thanks Ron!

New versions (3a) uploaded. Link above.

'nite!

Erik

PS. Yes, that bug has really been bugging me for a long time.

PPS. Version for TNG 12 coming soon to a Wiki near you.

[theKiwi 0]

7 hours ago, XerxX said:

A very strange code-change, in my opinion: HTML code becomes non-HTML for some reason...?

My modification keeps the underscore, however. I tested and it seems to work also without it.

The underscore was removed by Darrin as the fix for getting a blank window after doing an Edit, and then TNG can't close the window that was opened to do the edit.

So you should leave it removed to prevent problems.

Roger

[XerxX 0]

34 minutes ago, theKiwi said:

So you should leave it removed to prevent problems.

Ooops!

New version posted for 13.0.3 already. Will be changed in a second.

THANKS ROGER!

Erik

Edit: Fixed it. Version 13.0.3.3a has no underscores. Sorry about that.