Jump to content
TNG Community
pipsi

descendvert vs. verticalchart

Recommended Posts

pipsi

hello from Vienna,

I have successfully upgraded to V13 today. Very great that there is now a descendant vertical chart!

and - many thanks to all who updated the MODs for V13!

One question, is there any particular reason why the look and feel of the descendant vertical chart and ancestor vertical chart is different? 

 

Thank you in advance!

Ingrid

descendvert.PNG

verticalchart.PNG

Share this post


Link to post
Share on other sites
manofmull

Ingrid

I wondered that myself.

Just a guess, but I suspect it was simply to differentiate one chart from the other.

Your first image is clearly of the new descendants vertical.

If both charts were designed identically, it may cause confusion.

Share this post


Link to post
Share on other sites
Ken Roy

Actually, I might simply be because the Vertical Ancestor Chart was a mod in TNG v8 and v9 that was incorporated with that layout since TNG v12.   TNG v13 added the photos from the Verticalchart Photos mod

Share this post


Link to post
Share on other sites
manofmull

Ken

Of course, probably that. Would save Darrin having to code from scratch.

I used those mods from day one, until incorporated.

It is good to have the two styles.

Share this post


Link to post
Share on other sites
tngrlkrz
3 hours ago, manofmull said:

If both charts were designed identically, it may cause confusion.

To each his own.  I actually wanted the two charts to have the same style, so adjusted the new chart.  Easy to tell apart by tab and single box top, vs. single box bottom. 🙂

image.png

 

image.png

If you could put them together and you would have the bowtie chart. 😉

 

Share this post


Link to post
Share on other sites
manofmull

Ron

If only I knew how!

Have you made a mod?

I'd certainly try it.

Share this post


Link to post
Share on other sites
tngrlkrz

These are the adjustments I made to achieve a horizontal vs. vertical box.

Admin:Setup:Charts:Descendancy Chart:Vertical Chart

image.png

Then these changes (in Mod format ~ line 241-244) 

%target:descendvert.php%
%location:%
            $imagestr = "<img src=\"{$photoInfo['ref']}\" border=\"0\" style=\"max-width:100%;max-height:70px;margin-bottom:10px\" alt=\"\" class=\"thumb\" />";
            if($photoInfo['link'])
                $imagestr = "<a href=\"{$photoInfo['link']}\">$imagestr</a>";
            $boxstr .= "$imagestr<br/>";
%end:%
%replace:%
            $imagestr = "<img src=\"{$photoInfo['ref']}\" border=\"0\" style=\"float:left;max-width:40px;max-height:40px;margin-bottom:5px\" alt=\"\" class=\"thumb\" />";
            if($photoInfo['link'])
                $imagestr = "<a href=\"{$photoInfo['link']}\">$imagestr</a>";
            $boxstr .= "$imagestr.&nbsp;";
%end:%

 

Share this post


Link to post
Share on other sites
pipsi
vor 7 Stunden schrieb tngrlkrz:

These are the adjustments I made to achieve a horizontal vs. vertical box.

Admin:Setup:Charts:Descendancy Chart

image.png

Then these changes (in Mod format ~ line 241-244) 

%target:descendvert.php%
%location:%
            $imagestr = "<img src=\"{$photoInfo['ref']}\" border=\"0\" style=\"max-width:100%;max-height:70px;margin-bottom:10px\" alt=\"\" class=\"thumb\" />";
            if($photoInfo['link'])
                $imagestr = "<a href=\"{$photoInfo['link']}\">$imagestr</a>";
            $boxstr .= "$imagestr<br/>";
%end:%
%replace:%
            $imagestr = "<img src=\"{$photoInfo['ref']}\" border=\"0\" style=\"float:left;max-width:40px;max-height:40px;margin-bottom:5px\" alt=\"\" class=\"thumb\" />";
            if($photoInfo['link'])
                $imagestr = "<a href=\"{$photoInfo['link']}\">$imagestr</a>";
            $boxstr .= "$imagestr.&nbsp;";
%end:%

 

@tngrlkrz

I want to change that too - in which .php?

Thank you!
Ingrid

Share this post


Link to post
Share on other sites
klooster

Perfect, looks a lot better. I would suggest contacting Darrin to implement in next update!

Share this post


Link to post
Share on other sites
Ken Roy

The mod snippet published above only changes the image size used in the box to a smaller size. 

The orientation of the chart is controlled in the Admin > Setup > Chart Settings where you need to make the Pedigree and Descendancy Vertical Chart values the same.

It might be better to define a new CSS - smallimg class that is different than the thumb class so the style overrides were not hard-coded in the program.  Using a smallimg class definition could then be applied to the Standard charts as well so each site could decide how big they want to show the smallimg in the boxes

Share this post


Link to post
Share on other sites
pipsi
vor 37 Minuten schrieb klooster:

Perfect, looks a lot better. I would suggest contacting Darrin to implement in next update!

I asked Darrin via facebook The Next Generation of Genealogy Sitebuilding - att. his answer

Darrin.PNG

Share this post


Link to post
Share on other sites
tngrlkrz
1 hour ago, Ken Roy said:

The mod snippet published above only changes the image size used in the box to a smaller size.

The snippet also changes the way the thumb's position in the box, with the swap out of the <br/> for a "&nbsp;".   But yes, it was basically trial and error until the image was small enough to be positioned to the left instead of over the rest of the box content for the horizontal format.    Glad Darrin is considering adapting the style change.  

I actually have slightly different values for the boxes in Pedigree vs. Descendancy vertical charts in pedconfig.php, due to other changes in my own site.

 

Share this post


Link to post
Share on other sites
tngrlkrz
5 hours ago, pipsi said:

I want to change that too - in which .php?

Ingrid,

The first mod line specifies the TNG module for the vertical chart, the 'descendant vertical' chart:

%target:descendvert.php%

To make this easier, until Darrin implements a similar standardization via css styling, I was thinking to publish a small, mod along with appropriate instructions for the admin values to change. The changes seem to work with most if not all templates.

Share this post


Link to post
Share on other sites
tngrlkrz

I have posted a small mod on the wiki,  Descendant_Vertical_Chart_Adjust,  to achieve the results I noted above.  The admin:setup:chart settings are of course also required and noted in the Wiki article.  They can be adjusted to your needs.

Share this post


Link to post
Share on other sites
manofmull

Ron

Great job, installed and looks good.

Share this post


Link to post
Share on other sites
pipsi
vor 3 Stunden schrieb tngrlkrz:

I have posted a small mod on the wiki,  Descendant_Vertical_Chart_Adjust,  to achieve the results I noted above.  The admin:setup:chart settings are of course also required and noted in the Wiki article.  They can be adjusted to your needs.

THANK you!

kind regards, Ingrid

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×